Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug: one call to Job#set_status from `VmScan#call_snapshot_delete' has one extra parameter #14964

Merged
merged 2 commits into from
May 3, 2017
Merged

Fixed bug: one call to Job#set_status from `VmScan#call_snapshot_delete' has one extra parameter #14964

merged 2 commits into from
May 3, 2017

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented May 2, 2017 •
edited
Loading

One call to Job#set_status from VmScan#call_snapshot_delete had extra parameter.

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1458371

@miq-bot add-label bug, smart state, fine/no

@yrudman yrudman force-pushed the fixed-bug-in-vmscan-set_status branch from 45e14c7 to 5ce5dfa Compare May 2, 2017 16:27
@miq-bot
Copy link
Member

miq-bot commented May 2, 2017

Checked commits yrudman/manageiq@8af8c5b~...5ce5dfa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@isimluk
Copy link
Member

isimluk commented May 3, 2017

Maybe we may want this to be backported to fine. As this is follow-up on #14181 which is in already in fine.

@yrudman do you think it makes sense to file a bugzilla for this and backport?

Thanks!

@isimluk isimluk assigned isimluk and unassigned gtanzillo May 3, 2017
@isimluk isimluk added fine/yes and removed fine/no labels May 3, 2017
@isimluk isimluk added this to the Sprint 60 Ending May 8, 2017 milestone May 3, 2017
@isimluk isimluk merged commit f90652d into ManageIQ:master May 3, 2017
@yrudman yrudman deleted the fixed-bug-in-vmscan-set_status branch May 3, 2017 12:36
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

@yrudman Is there a BZ for this? Can you please create if it doesn't exist?

@yrudman
Copy link
Contributor Author

yrudman commented Jun 2, 2017 •
edited
Loading

@simaishi BZ created: https://bugzilla.redhat.com/show_bug.cgi?id=1458371

@yrudman
Copy link
Contributor Author

yrudman commented Jun 2, 2017

@miq-bot remove-label bugzilla needed

simaishi pushed a commit that referenced this pull request Jun 2, 2017
@isimluk @simaishi
Merge pull request #14964 from yrudman/fixed-bug-in-vmscan-set_status
08455e1 
Fixed bug: one call to Job#set_status from `VmScan#call_snapshot_delete' has one extra parameter
(cherry picked from commit f90652d)

https://bugzilla.redhat.com/show_bug.cgi?id=1458445
@simaishi
Copy link
Contributor

simaishi commented Jun 2, 2017

Fine backport details:

$ git log -1
commit 08455e1b0e0c2a93b29042c3eeb9018922fa8333
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Wed May 3 10:44:22 2017 +0200

    Merge pull request #14964 from yrudman/fixed-bug-in-vmscan-set_status
    
    Fixed bug: one call to Job#set_status from `VmScan#call_snapshot_delete' has one extra parameter
    (cherry picked from commit f90652d3d131388ea2819e84c2fbbd431d956f8a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@isimluk isimluk

Labels
bug core/smart state fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yrudman @miq-bot @isimluk @simaishi @gtanzillo