Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network_ports relation of a LB #14969

Merged
merged 1 commit into from
May 3, 2017
Merged

Fix network_ports relation of a LB #14969

merged 1 commit into from
May 3, 2017

Conversation

Ladas
Copy link
Contributor

@Ladas Ladas commented May 3, 2017 •
edited
Loading

@Ladas
Copy link
Contributor Author

Ladas commented May 3, 2017

@miq-bot assign @agrare

@miq-bot
Copy link
Member

miq-bot commented May 3, 2017

Checked commit Ladas@5a5d38f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

This was referenced May 3, 2017
Merged
Merged
agrare
agrare approved these changes May 3, 2017
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrare agrare merged commit 0ee5e4c into ManageIQ:master May 3, 2017
@agrare agrare added this to the Sprint 60 Ending May 8, 2017 milestone May 3, 2017
@Ladas
Copy link
Contributor Author

Ladas commented May 10, 2017

@miq-bot add_label fine/yes euwe/yes

@miq-bot
Copy link
Member

miq-bot commented May 10, 2017

@Ladas Cannot apply the following label because they are not recognized: fine/yes euwe/yes

@Ladas
Copy link
Contributor Author

Ladas commented May 10, 2017

@miq-bot add_label fine/yes, euwe/yes

@Ladas
Copy link
Contributor Author

Ladas commented May 10, 2017

@miq-bot remove_label euwe/yes

@miq-bot miq-bot removed the euwe/yes label May 10, 2017
simaishi pushed a commit that referenced this pull request Jun 5, 2017
@agrare @simaishi
Merge pull request #14969 from Ladas/fix_network_ports_relation_of_lb
8430359 
Fix network_ports relation of a LB
(cherry picked from commit 0ee5e4c)

https://bugzilla.redhat.com/show_bug.cgi?id=1458374
https://bugzilla.redhat.com/show_bug.cgi?id=1458943
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

Fine backport details:

$ git log -1
commit 8430359aab07356035925eda8e0d2c44e399bd5e
Author: Adam Grare <agrare@redhat.com>
Date:   Wed May 3 09:00:23 2017 -0400

    Merge pull request #14969 from Ladas/fix_network_ports_relation_of_lb
    
    Fix network_ports relation of a LB
    (cherry picked from commit 0ee5e4ccbf073be3e4305ad1e865a23d22b321f4)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458374
    https://bugzilla.redhat.com/show_bug.cgi?id=1458943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

Assignees

@agrare agrare

Labels
bug fine/backported providers/network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ladas @miq-bot @simaishi @agrare