-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add :sort_by: :none to GCE Boot Disk Size dialog field. #14981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lfu Would prefer we use the key |
Use :sort_by: :none to keep the values in the order that they are inserted in the file. https://bugzilla.redhat.com/show_bug.cgi?id=1389010
lfu
force-pushed
the
dialog_field_sort_none_1389010
branch
from
May 3, 2017 19:15
e5fefc8
to
b91d017
Compare
lfu
changed the title
Add :sort: :none to GCE Boot Disk Size dialog field.
Add :sort_by: :none to GCE Boot Disk Size dialog field.
May 3, 2017
Checked commit lfu@b91d017 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
gmcculloug
approved these changes
May 3, 2017
simaishi
pushed a commit
that referenced
this pull request
May 12, 2017
Add :sort_by: :none to GCE Boot Disk Size dialog field. (cherry picked from commit f86c62d) https://bugzilla.redhat.com/show_bug.cgi?id=1449403
Euwe backport details:
|
simaishi
pushed a commit
that referenced
this pull request
Jun 5, 2017
Add :sort_by: :none to GCE Boot Disk Size dialog field. (cherry picked from commit f86c62d) https://bugzilla.redhat.com/show_bug.cgi?id=1458447
Fine backport details:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use :sort_by: :none to keep the field values in the order that they are inserted in the file.
UI part #1248.
https://bugzilla.redhat.com/show_bug.cgi?id=1389010
@miq-bot assign @gmcculloug
@miq-bot add_label bug, provisioning, euwe/yes, fine/yes