Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add :sort_by: :none to GCE Boot Disk Size dialog field. #14981

Merged
merged 1 commit into from
May 3, 2017

Conversation

lfu
Copy link
Member

@lfu lfu commented May 3, 2017

Use :sort_by: :none to keep the field values in the order that they are inserted in the file.

UI part #1248.
https://bugzilla.redhat.com/show_bug.cgi?id=1389010

@miq-bot assign @gmcculloug
@miq-bot add_label bug, provisioning, euwe/yes, fine/yes

@gmcculloug
Copy link
Member

@lfu Would prefer we use the key :sort_by to align with field names used in the Service Dialogs.

Use :sort_by: :none to keep the values in the order that they are inserted in the file.
https://bugzilla.redhat.com/show_bug.cgi?id=1389010
@lfu lfu force-pushed the dialog_field_sort_none_1389010 branch from e5fefc8 to b91d017 Compare May 3, 2017 19:15
@lfu lfu changed the title Add :sort: :none to GCE Boot Disk Size dialog field. Add :sort_by: :none to GCE Boot Disk Size dialog field. May 3, 2017
@miq-bot
Copy link
Member

miq-bot commented May 3, 2017

Checked commit lfu@b91d017 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@gmcculloug gmcculloug merged commit f86c62d into ManageIQ:master May 3, 2017
@gmcculloug gmcculloug added this to the Sprint 60 Ending May 8, 2017 milestone May 3, 2017
simaishi pushed a commit that referenced this pull request May 12, 2017
Add :sort_by: :none to GCE Boot Disk Size dialog field.
(cherry picked from commit f86c62d)

https://bugzilla.redhat.com/show_bug.cgi?id=1449403
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 630f8216e0848c2a0715054f386bb962b6e3c6df
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed May 3 17:44:16 2017 -0400

    Merge pull request #14981 from lfu/dialog_field_sort_none_1389010
    
    Add :sort_by: :none to GCE Boot Disk Size dialog field.
    (cherry picked from commit f86c62d82edc32016e62b7a1dd866f0dac70781c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1449403

simaishi pushed a commit that referenced this pull request Jun 5, 2017
Add :sort_by: :none to GCE Boot Disk Size dialog field.
(cherry picked from commit f86c62d)

https://bugzilla.redhat.com/show_bug.cgi?id=1458447
@simaishi
Copy link
Contributor

simaishi commented Jun 5, 2017

Fine backport details:

$ git log -1
commit 986d7565a1587a6f832378a8d30a2dd4491ead0e
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Wed May 3 17:44:16 2017 -0400

    Merge pull request #14981 from lfu/dialog_field_sort_none_1389010
    
    Add :sort_by: :none to GCE Boot Disk Size dialog field.
    (cherry picked from commit f86c62d82edc32016e62b7a1dd866f0dac70781c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1458447

@lfu lfu deleted the dialog_field_sort_none_1389010 branch October 16, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants