Service Playbook updates fqname and configuration_template

[bzwei]

Multiple problems were discovered while debugging https://bugzilla.redhat.com/show_bug.cgi?id=1447701

1. Fix update process to include :fqname for resource_actions
2. Embedded job template, aka configuration_template, should not be recorded in options[:config_info]
3. Method #create_dialogs can be used both by create_catalog_item and update_catalog_item

[bzwei]

@miq-bot add_label bug, providers/ansible_tower, services, fine/yes, blocker
@miq-bot assign @gmcculloug
cc @syncrou @jntullo

[syncrou]

@bzwei - I was testing this with the following scenario:

1. Create new Ansible Playbook catalog item with no retirement playbook.
2. Edit the catalog item and add a new retirement playbook.
3. Edit the catalog item and remove the retirement playbook.
4. Delete the entire catalog item.

With part 4 I ran into this error:

I'm not entirely sure the error came from your changes - but I believe it failed here. I'd be interested if you can duplicate it on your environment.

[bzwei]

@syncrou please test with latest commit.

[syncrou]

I believe this will fail without the to_s. There may be more.

[bzwei]

I tested and proved to_s can be dropped.

[syncrou]

With the latest changes I'm not able to get as far as before.

Using the following scenario:

1. Create new Ansible Playbook catalog item with no retirement playbook.
2. Edit the catalog item and add a new retirement playbook.
3. Edit the catalog item and remove the retirement playbook.
4. Delete the entire catalog item.

I am failing at 2. The retirement resource_action is created:

But the retirement playbook is not created in Tower:

[syncrou]

What do you think about passing the action to delete_job_templates? Then line 223 could be deleted.

  def delete_job_templates(job_templates, action = nil)
    auth_user = User.current_userid || 'system'
    job_templates.each do |job_template|
      ManageIQ::Providers::EmbeddedAnsible::AutomationManager::ConfigurationScript
        .delete_in_provider_queue(job_template.manager.id, { :manager_ref => job_template.manager_ref }, auth_user)
    end
   resource_actions.find_by(:action => action.capitalize).update_attributes(:configuration_template => nil) if action
  end

[miq-bot]

Checked commits bzwei/manageiq@dcece3e~...2dc391f with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐

[syncrou]

👍 Looks good to me

[simaishi]

Fine backport details:

$ git log -1
commit 6abd7a6bcd96e2fad317aa05e6ec9932f39d8e62
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Mon May 8 08:58:09 2017 -0400

    Merge pull request #15007 from bzwei/retire_playbook_update
    
    Service Playbook updates fqname and configuration_template
    (cherry picked from commit fc36cd5817ec9ce58828870911b8880691d3a5e6)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1448868