Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize MiqServer #15014

Closed

Commits on May 5, 2017

  1. Remove MiqServer::WorkerManagement::Monitor::Kill

    Moved the methods into app/models/miq_server.rb and
    app/models/miq_server/worker_management/quiesce.rb since each of those
    files are basically the ones that use them.
    
    `kill_all_workers` will actually be moved in a later commit to
    modularize the core methods of MiqServer.
    NickLaMuro committed May 5, 2017
    Configuration menu
    Copy the full SHA
    7214dac View commit details
    Browse the repository at this point in the history
  2. Move core MiqServer constants into a module

    Moves them into a module for reusablity.  Freezes ones that haven't been
    frozen already.
    NickLaMuro committed May 5, 2017
    Configuration menu
    Copy the full SHA
    896e8b6 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2017

  1. Adds MiqServerBaseMethods

    Moves common methods out of MiqServer to be reused in a later commit.
    NickLaMuro committed May 6, 2017
    Configuration menu
    Copy the full SHA
    1752ade View commit details
    Browse the repository at this point in the history
  2. Adds MiqServerWorkerManagementBase

    Moves "srsly everything" in app/models/miq_server/worker_management.rb
    into it's own module for reuse.
    
    Used a concern here since it seems to handle things better, but can't
    use `include_concern` because that doesn't support non-standard paths
    (yet...)
    NickLaMuro committed May 6, 2017
    Configuration menu
    Copy the full SHA
    6621ea7 View commit details
    Browse the repository at this point in the history
  3. Moves MiqServer::QueueManagement to MiqServerQueueManagement

    Allows MiqServerQueueManagement to be reused without loading MiqServer
    NickLaMuro committed May 6, 2017
    Configuration menu
    Copy the full SHA
    41d2f08 View commit details
    Browse the repository at this point in the history