Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Start Pages dropdown list - Clouds menus #15017

Merged
merged 11 commits into from
May 20, 2017

Conversation

GregP
Copy link
Contributor

@GregP GregP commented May 5, 2017

NOTE: This PR requires MiqShortcut.seed to be run to re-populate database table.

NOTE: In order to check Datawarehouse and Monitor Alerts shortcuts and menu display settings need to change in Configuration => Server => Advanced tab, see screen shots below for actual settings change/addition if needed.

https://bugzilla.redhat.com/show_bug.cgi?id=1331327

At Login Start Page drop down list in My Settings => Visual tab is not in sync with recent UI menu navigation changes/updates.

Code updates provided via multiple commits, each matching UI menu section.

Screen shots of Start Page drop down list PRIOR to code fixes:
all start pages list prior to update 1

all start pages list prior to update 2

all start pages list prior to update 3

all start pages list prior to update 4

all start pages list prior to update 5

Screen shots of Start Page drop down AFTER code fixes:

start page at login cloud intel short cuts post fix

start page at login services short cuts post fix

start page at login compute clouds short cuts post fix

start page at login compute infrastructure short cuts post fix

start page at login compute containers short cuts post fix

start page at login configuration short cuts post fix

start page at login networks short cuts post fix

start page at login middleware short cuts post fix

start page at login storage short cuts post fix

start page at login control short cuts post fix

start page at login automation short cuts post fix

start page at login optimize short cuts post fix

NOTE: In order to see Datawarehouse and Monitor Alerts menus display in UI, change/add following settings in (top right corner) Configuration => Server => Advanced Tab:

datawarehouse and monitor alerts settings change in config server advanced tab

UI Datawarehouse menu displayed post settings set/save:

datawarehouse and monitor alerts menus post settings change

@GregP
Copy link
Contributor Author

GregP commented May 8, 2017

@h-kataria Please review.

@dclarizio
Copy link

@chessbyte please assign to @h-kataria, she can review this. Thx, Dan

@GregP GregP force-pushed the syncup_start_page_dropdown_list branch from 2c04e6d to 19ce1d3 Compare May 9, 2017 21:29
@GregP
Copy link
Contributor Author

GregP commented May 9, 2017

@h-kataria Added Datawarehouse and Monitor Alerts, per discussion. Added notes and screen shots to assist in settings addition/update to display these menus in UI. Ready for review.

@GregP GregP closed this May 10, 2017
@GregP GregP reopened this May 10, 2017
:startup: true
- :name: vms_mytemplates
:description: Services / Workloads / Templates & Images
:url: /vm_or_template/explorer?accordion=templates_images_filter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GregP we need to keep all VM explorer related start page entries that allows user to be able to set a specific accordion as their start page. See my screenshot below where i have set "Services / Workloads/ Templates & Images" accordion to be my start page.
screenshot from 2017-05-13 13-27-00

@GregP
Copy link
Contributor Author

GregP commented May 13, 2017

@h-kataria We do not have those in the defaults file? One of my commits deleted Workloads/xxx shortcuts, I can put those back, just don't see them listed in the defaults (matching) file?

@GregP GregP force-pushed the syncup_start_page_dropdown_list branch from a154144 to 3e1fc43 Compare May 15, 2017 20:25
@miq-bot
Copy link
Member

miq-bot commented May 15, 2017

This pull request is not mergeable. Please rebase and repush.

@GregP GregP force-pushed the syncup_start_page_dropdown_list branch from 3e1fc43 to 76f212d Compare May 15, 2017 20:29
@GregP
Copy link
Contributor Author

GregP commented May 15, 2017

@h-kataria Services short cuts re-instated, ready for review.

@GregP GregP force-pushed the syncup_start_page_dropdown_list branch 3 times, most recently from e0e557e to e73eba9 Compare May 17, 2017 21:11
@GregP
Copy link
Contributor Author

GregP commented May 17, 2017

@h-kataria All short cuts should be up to date now, ready for review.

@GregP GregP force-pushed the syncup_start_page_dropdown_list branch 3 times, most recently from cf6c604 to 268cf04 Compare May 17, 2017 22:22
@GregP
Copy link
Contributor Author

GregP commented May 17, 2017

@h-kataria Shortcuts amended to streamline Services, Compute Clouds Instances and Compute Clouds Infrastructure, ready for review.

@GregP GregP force-pushed the syncup_start_page_dropdown_list branch from 268cf04 to 97d2b8e Compare May 17, 2017 22:31
@@ -53,208 +53,439 @@
:description: Services / Workloads / Provision VMs
:url: /vm_or_template/explorer?button=vm_miq_request_new
:rbac_feature_name: vm_miq_request_new
:startup: false
:startup: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GregP any idea why this is changed to true, i don't remember what is the use of setting startup attribute here, is that being used to ignore the shortcut entry during seeding or something. Can you please check.

@GregP GregP force-pushed the syncup_start_page_dropdown_list branch from db2bf1d to 7eb0212 Compare May 18, 2017 15:02
@GregP GregP force-pushed the syncup_start_page_dropdown_list branch from 7eb0212 to 54d185e Compare May 18, 2017 15:02
@GregP
Copy link
Contributor Author

GregP commented May 18, 2017

@h-kataria I think I switched it to true while applying all the later changes/additions and testing yesterday. Changed it back to false, its original setting. Ready for review.

@miq-bot
Copy link
Member

miq-bot commented May 18, 2017

Checked commits GregP/manageiq@a127caf~...54d185e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@h-kataria
Copy link
Contributor

@chessbyte looks good to be merged

@chessbyte chessbyte merged commit 1cfd7d0 into ManageIQ:master May 20, 2017
@chessbyte chessbyte added this to the Sprint 61 Ending May 22, 2017 milestone May 20, 2017
@simaishi
Copy link
Contributor

simaishi commented Aug 4, 2017

@GregP There are a few conflicts backporting this to Fine branch. Can you create a PR for FIne branch?

@simaishi
Copy link
Contributor

Backported to Fine via #15734

@kbrock kbrock mentioned this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants