-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Start Pages dropdown list - Clouds menus #15017
Login Start Pages dropdown list - Clouds menus #15017
Conversation
@h-kataria Please review. |
@chessbyte please assign to @h-kataria, she can review this. Thx, Dan |
2c04e6d
to
19ce1d3
Compare
@h-kataria Added Datawarehouse and Monitor Alerts, per discussion. Added notes and screen shots to assist in settings addition/update to display these menus in UI. Ready for review. |
db/fixtures/miq_shortcuts.yml
Outdated
:startup: true | ||
- :name: vms_mytemplates | ||
:description: Services / Workloads / Templates & Images | ||
:url: /vm_or_template/explorer?accordion=templates_images_filter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GregP we need to keep all VM explorer related start page entries that allows user to be able to set a specific accordion as their start page. See my screenshot below where i have set "Services / Workloads/ Templates & Images" accordion to be my start page.
@h-kataria We do not have those in the defaults file? One of my commits deleted Workloads/xxx shortcuts, I can put those back, just don't see them listed in the defaults (matching) file? |
a154144
to
3e1fc43
Compare
This pull request is not mergeable. Please rebase and repush. |
3e1fc43
to
76f212d
Compare
@h-kataria Services short cuts re-instated, ready for review. |
e0e557e
to
e73eba9
Compare
@h-kataria All short cuts should be up to date now, ready for review. |
cf6c604
to
268cf04
Compare
@h-kataria Shortcuts amended to streamline Services, Compute Clouds Instances and Compute Clouds Infrastructure, ready for review. |
268cf04
to
97d2b8e
Compare
db/fixtures/miq_shortcuts.yml
Outdated
@@ -53,208 +53,439 @@ | |||
:description: Services / Workloads / Provision VMs | |||
:url: /vm_or_template/explorer?button=vm_miq_request_new | |||
:rbac_feature_name: vm_miq_request_new | |||
:startup: false | |||
:startup: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GregP any idea why this is changed to true, i don't remember what is the use of setting startup attribute here, is that being used to ignore the shortcut entry during seeding or something. Can you please check.
db2bf1d
to
7eb0212
Compare
https://bugzilla.redhat.com/show_bug.cgi?id=1331327 Amended Services shortcuts to delete Workloads https://bugzilla.redhat.com/show_bug.cgi?id=1331327
7eb0212
to
54d185e
Compare
@h-kataria I think I switched it to true while applying all the later changes/additions and testing yesterday. Changed it back to false, its original setting. Ready for review. |
Checked commits GregP/manageiq@a127caf~...54d185e with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@chessbyte looks good to be merged |
@GregP There are a few conflicts backporting this to Fine branch. Can you create a PR for FIne branch? |
Backported to Fine via #15734 |
NOTE: This PR requires MiqShortcut.seed to be run to re-populate database table.
NOTE: In order to check Datawarehouse and Monitor Alerts shortcuts and menu display settings need to change in Configuration => Server => Advanced tab, see screen shots below for actual settings change/addition if needed.
https://bugzilla.redhat.com/show_bug.cgi?id=1331327
At Login Start Page drop down list in My Settings => Visual tab is not in sync with recent UI menu navigation changes/updates.
Code updates provided via multiple commits, each matching UI menu section.
Screen shots of Start Page drop down list PRIOR to code fixes:
Screen shots of Start Page drop down AFTER code fixes:
NOTE: In order to see Datawarehouse and Monitor Alerts menus display in UI, change/add following settings in (top right corner) Configuration => Server => Advanced Tab:
UI Datawarehouse menu displayed post settings set/save: