Use ActiveRecord::Base for connection info #15019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not ApplicationRecord, since it might not be defined, and ActiveRecord::Base.connection is what is used everywhere else in this class.
|
Checked commit NickLaMuro@1c28035 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
NickLaMuro
added a commit
to NickLaMuro/manageiq
that referenced
this pull request
May 9, 2017
This is a commit to help implement the features implemented in the
following PRs:
ManageIQ#14953
ManageIQ#14967
ManageIQ#15014
ManageIQ#15018
ManageIQ#15019
ManageIQ#15020
Meant to illustrate how they will eventually be used in this PR, and
show how they will be implemented when they are merged into master.
The prior commits to this one are left in place to show before and
after, but this and those will be removed in the final iteration of this
pull request, and only the necessary changes needed to implement this in
the Rake tasks will be part of this PR.
Applying all of the changes for this PR was done as follows:
$ git apply <(curl -L ManageIQ#14953)
$ git apply <(curl -L ManageIQ#14967)
$ git apply <(curl -L ManageIQ#15014)
$ git apply <(curl -L ManageIQ#15018)
$ git apply <(curl -L ManageIQ#15019)
$ git apply <(curl -L ManageIQ#15020)
And then with some extra changes on top of that:
* Making use of `Miq.env` and `Miq.root` where relevant
* Implementing the modulularized PRs in the `tools/utils/mini_*.rb`
files where relavant
* Various bug fixes (though some seem like they shouldn't be there...)
Again, this is meant as a demonstration commit to show the before and
after while this is still a POC. Once the necessary pieces are in place
on master to make this commit irrelevant, it will be rebased out. It
may also change over time as this PR is worked on further.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use
ApplicationRecordfor this purpose since it might not be defined, andActiveRecord::Base.connectionis what is used everywhere else in this class.Another support PR for #14916
Links