Reduce the default oVirt open timeout to 1 minute

[jhernand]

Currently the timeout used when opening connections to oVirt isn't
explicitly set. That means that when trying to connect to an oVirt
system that doesn't exist, or that doesn't respond, it may take as long
as the TCP timeout till the error is detected. In a typical setup on top
of Linux this timeout is approx 2 minutes and 8 seconds. But in
production environments the web server that is in front of the ManageIQ
user interface has a request timeout explicitly set to 2 minutes. This
means that validation of credentials for oVirt systems that don't exist,
or don't respond are ignored by the ManageIQ user interface, because it
gives up before the error is detected by the ManageIQ server. To avoid
that issue this patch changes the default connection timeout used by the
oVirt provider to 1 minute.

https://bugzilla.redhat.com/1448065

[jhernand]

@masayag @borod108 please review.

[miq-bot]

Checked commit https://github.com/jhernand/manageiq/commit/ec8664221bd59a129e63ea12092f44a8f41f9106 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

[borod108]

Great fix.

[chessbyte]

@jhernand Maybe you should move the whole ems_redhat section of settings to https://github.com/ManageIQ/manageiq-providers-ovirt/blob/master/config/settings.yml

[jhernand]

@chessbyte yes, that makes sense. How are upgrades managed in that case? I mean, what will happen for users that already did changes to their global settings file? Will the settings in the provider specific file override the settings in the global file or the other way around?

[bdunne]

@jhernand Users shouldn't be changing anything in settings.yaml. Any settings changes should be done through the UI which are then saved in the database.

For extra credit, it would be nice if the key was also changed to ems_ovirt to match the provider plugin name. For this, you'll need a migration to update any settings records in the database.

[bdunne]

@jhernand Please add a Fine label

[jhernand]

@miq-bot add_label fine/yes

[simaishi]

Fine backport details:

$ git log -1
commit 10effaeaf66ad8697dba892339ac93c57ba2ff6f
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Wed May 17 07:47:42 2017 -0400

    Merge pull request #15099 from jhernand/reduce_default_ovirt_open_timeout
    
    Reduce the default oVirt open timeout to 1 minute
    (cherry picked from commit 7e05340118a44de6614de1ebbfdff272daf2b45a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1461860