Use extra_vars to create a new dialog when editing Ansible playbook service template. #15120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bzwei Is it possible to create the dialog using the options stored in the service_template instead of having to incur more synchronous queue refreshes? |
|
@lfu you can modify https://github.com/ManageIQ/manageiq/blob/master/app/models/dialog/ansible_playbook_service_dialog.rb#L9 The extra_vars from service_template is no longer a plain hash. Actually it helps better the dialog tool to create appropriate fields based on the metadata. |
lfu
force-pushed
the
svc_dialog_extra_vars_1450102
branch
from
7c027f9
to
8821393
Compare
lfu
changed the title
…ervice template. Use the new values in extra_vars to create a new dialog, instead of waiting for the updated job template which may take some time. https://bugzilla.redhat.com/show_bug.cgi?id=1450102
lfu
force-pushed
the
svc_dialog_extra_vars_1450102
branch
from
8821393
to
76bae5b
Compare
|
Checked commit lfu@76bae5b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bzwei
approved these changes
May 19, 2017
simaishi
pushed a commit
that referenced
this pull request
Jun 8, 2017
Use extra_vars to create a new dialog when editing Ansible playbook service template. (cherry picked from commit 0613afb) https://bugzilla.redhat.com/show_bug.cgi?id=1459989
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new values in extra_vars to create a new dialog, instead of waiting for the updated job template which may take some time.
https://bugzilla.redhat.com/show_bug.cgi?id=1450102
@miq-bot assign @gmcculloug
@miq-bot add_label bug, fine/yes, providers/ansible_tower, services