Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Host#refresh_linux_packages #15161

Merged
merged 1 commit into from
May 19, 2017
Merged

Add test for Host#refresh_linux_packages #15161

merged 1 commit into from
May 19, 2017

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented May 19, 2017

Based on #15140

@bdunne bdunne requested review from jrafanie and Fryguy May 19, 2017 13:14
@bdunne
Copy link
Member Author

bdunne commented May 19, 2017

@NaNi-Z Please review. This would not have been an easy first test to add because of the XML parsing. 😄

@miq-bot
Copy link
Member

miq-bot commented May 19, 2017

Checked commit bdunne@068a609 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

jrafanie
jrafanie approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a hard test to write because it's really low level stuff you're testing from a higher level. I can't think of a better way though.

@chessbyte chessbyte self-assigned this May 19, 2017
@chessbyte chessbyte merged commit ae17684 into ManageIQ:master May 19, 2017
@chessbyte chessbyte added this to the Sprint 61 Ending May 22, 2017 milestone May 19, 2017
@bdunne bdunne deleted the add_test_for_host_refresh_linux_packages branch May 19, 2017 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrafanie jrafanie jrafanie approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees

@chessbyte chessbyte

Labels
enhancement test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bdunne @miq-bot @jrafanie @chessbyte