Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save resource group information #15187

Merged
merged 1 commit into from
Jun 7, 2017
Merged

Save resource group information #15187

merged 1 commit into from
Jun 7, 2017

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented May 22, 2017

We have a resource_group table within our schema, but it seems that resource group information cannot be saved by the providers yet. The first issue is that resource groups are being saved too late. The second issue is that they need to be explicitly added to the save_inventory call.

Depends on #14948 to work properly for images.

@djberg96
Copy link
Contributor Author

@Ladas Is this all that needs to be done on the main repo?

@miq-bot miq-bot added the wip label May 22, 2017
@Ladas
Copy link
Contributor

Ladas commented May 22, 2017

@djberg96 I think so, if it passes refresh tests (and we test the association) it should be ok :-)

@djberg96
Copy link
Contributor Author

@Ladas I can't seem to get it to work. I'm working on this local dev branch, and I'm pointing my Gemfile at ManageIQ/manageiq-providers-azure#72. It doesn't fail, but the resource_group_id isn't getting set.

Note that I also tried applying the changes I proposed at #14948, but to no effect.

Any ideas?

@Ladas
Copy link
Contributor

Ladas commented May 23, 2017

@djberg96 the ordering looks ok, since you've put it on a 1st place in saver and parser. So I think that the ems_ref doesn't match most likely? Can you put a breakpoint into parser and see if @data_index.fetch_path(:resource_groups, rg_ems_ref) actually returns the resource_group?

@djberg96
Copy link
Contributor Author

@Ladas Upon further review, it looks like I needed to add resource_group to the list of cloud keys to avoid type mismatch errors. Sorry about that.

@miq-bot
Copy link
Member

miq-bot commented May 23, 2017

Checked commit https://github.com/djberg96/manageiq/commit/ec39ab6ae2d98948555b99c66a30b35e6b0084ab with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

@Ladas
Copy link
Contributor

Ladas commented May 23, 2017

@djberg96 ah right, sorry. Yes, that causes the ignore the :resource_group when saving and taking only :resource_group_id

@djberg96 djberg96 changed the title [WIP] Save resource group information Save resource group information Jun 5, 2017
@djberg96
Copy link
Contributor Author

djberg96 commented Jun 5, 2017

With #14948 merged this is ready to be merged.

@Ladas @blomquisg Please review and merge if it looks good.

@miq-bot miq-bot removed the wip label Jun 5, 2017
@blomquisg blomquisg merged commit e4dd3f6 into ManageIQ:master Jun 7, 2017
@blomquisg blomquisg added this to the Sprint 63 Ending Jun 19, 2017 milestone Jun 7, 2017
@djberg96 djberg96 deleted the resource_group_assoc branch July 17, 2017 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants