-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save resource group information #15187
Conversation
@Ladas Is this all that needs to be done on the main repo? |
@djberg96 I think so, if it passes refresh tests (and we test the association) it should be ok :-) |
@Ladas I can't seem to get it to work. I'm working on this local dev branch, and I'm pointing my Gemfile at ManageIQ/manageiq-providers-azure#72. It doesn't fail, but the resource_group_id isn't getting set. Note that I also tried applying the changes I proposed at #14948, but to no effect. Any ideas? |
@djberg96 the ordering looks ok, since you've put it on a 1st place in saver and parser. So I think that the ems_ref doesn't match most likely? Can you put a breakpoint into parser and see if @data_index.fetch_path(:resource_groups, rg_ems_ref) actually returns the resource_group? |
@Ladas Upon further review, it looks like I needed to add |
Checked commit https://github.com/djberg96/manageiq/commit/ec39ab6ae2d98948555b99c66a30b35e6b0084ab with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@djberg96 ah right, sorry. Yes, that causes the ignore the :resource_group when saving and taking only :resource_group_id |
With #14948 merged this is ready to be merged. @Ladas @blomquisg Please review and merge if it looks good. |
We have a resource_group table within our schema, but it seems that resource group information cannot be saved by the providers yet. The first issue is that resource groups are being saved too late. The second issue is that they need to be explicitly added to the save_inventory call.
Depends on #14948 to work properly for images.