Do not queue C&U for things that dont support it #15195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
reviewed
May 24, 2017
| @@ -1,4 +1,6 @@ | |||
| class ManageIQ::Providers::Microsoft::InfraManager::Host < ::Host | |||
| supports_not :metrics | |||
There was a problem hiding this comment.
is there any let's say technical reason why the model is supporting metrics ?
There was a problem hiding this comment.
responded in the dependecy pr
|
This pull request is not mergeable. Please rebase and repush. |
isimluk
force-pushed
the
do-not-CU-things-that-dont-support-it
branch
from
43bf24a
to
ca2d22d
Compare
isimluk
force-pushed
the
do-not-CU-things-that-dont-support-it
branch
from
ca2d22d
to
97c63bb
Compare
|
Checked commit isimluk@97c63bb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
durandom
approved these changes
Jun 20, 2017
Ich bin beleidigt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCVMM does not support C&U, do not schedule it, it would traceback hard anyway.