Add pretty model name for physical server #15283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
force-pushed
the
add_model_name_for_physical_server
branch
from
f7c4907
to
b4d9e56
Compare
AparnaKarve
reviewed
Jun 2, 2017
| @@ -886,6 +887,7 @@ en: | |||
| OrchestrationTemplateVnfd: VNF Template | |||
| ManageIQ::Providers::Vmware::CloudManager::OrchestrationTemplate: vApp Template | |||
| PersistentVolume: Persistent Volume | |||
| PhysicalServer: Physical Server | |||
There was a problem hiding this comment.
#15275 is a dup of this PR (merged yesterday)
Although I might have missed adding the entry on L#890.
Do we need it? (since I did not see it for Physical Infrastructure Provider)
If yes, let's keep the PR. Thanks.
There was a problem hiding this comment.
@AparnaKarve Yes, it is needed for us being able to translate breadcrumb in physical server list view.
mzazrivec
force-pushed
the
add_model_name_for_physical_server
branch
from
b4d9e56
to
db9e747
Compare
|
Checked commit mzazrivec@db9e747 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
