Remove miq_server #15284
Merged
Remove miq_server #15284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
abellotti
reviewed
Jun 2, 2017
| rescue => err | ||
| action_result(false, "Failed to set miq_server - #{err}") | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def miq_server_message(miq_server) | ||
| return 'Removed miq_server' unless miq_server | ||
| "Set miq_server id:#{miq_server.id}" |
There was a problem hiding this comment.
ternary one-liner, also pick one quoting for both, " " or ' '.
|
Checked commit jntullo@453b607 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM!! Thanks @jntullo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up #15262, the
set_miq_serveraction needs to be able to set anmiq_serverto nil (removing the currentmiq_server). This PR updates the functionality by accepting an empty hash, ie:{ "action": "set_miq_server", "miq_server": {} }which will then set the
miq_serverto nil.@miq-bot add_label api, enhancement, fine/no
@miq-bot assign @abellotti
cc: @h-kataria