Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put time back the way we found it #15301

Merged

Conversation

imtayadeway
Copy link
Contributor

These tests use Timecop.travel without Timecop.return, causing
another test in another part of the suite to fail. To reproduce:

SPEC_OPTS=--seed=30045 bundle exec rspec ./spec/models/job_spec.rb[1:1:7:1:1] ./spec/requests/api/logging_spec.rb[1:1:4]

Fixes #15290

@miq-bot add-label bug/sporadic test failure
@miq-bot assign @jrafanie

These tests use `Timecop.travel` without `Timecop.return`, causing
another test in another part of the suite to fail. To reproduce:

```
SPEC_OPTS=--seed=30045 bundle exec rspec ./spec/models/job_spec.rb[1:1:7:1:1] ./spec/requests/api/logging_spec.rb[1:1:4]
```

Fixes ManageIQ#15290
@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2017

Checked commit imtayadeway@ba17014 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@jrafanie
Copy link
Member

jrafanie commented Jun 5, 2017

@imtayadeway ugh, tests are failing

  1) EmsEvent.event_groups returns a list of groups
     Failure/Error: expect(described_class.event_groups[:addition][:critical]).to include('CloneTaskEvent')
       expected ["aggregate.addhost.end", "aggregate.create.end", "aggregate.removehost.end", "aggregate.updateprop.e...es_write_EndRequest", "CONTAINER_CREATED", "REPLICATOR_SUCCESSFULCREATE", "REPLICATOR_FAILEDCREATE"] to include "CloneTaskEvent"
     # ./spec/models/ems_event_spec.rb:212:in `block (3 levels) in <top (required)>'
  2) EmsEvent.event_groups returns the provider event if configured
     Failure/Error: expect(described_class.event_groups[:addition][:critical]).to include('CloneTaskEvent')
       expected ["aggregate.addhost.end", "aggregate.create.end", "aggregate.removehost.end", "aggregate.updateprop.e...INER_CREATED", "REPLICATOR_SUCCESSFULCREATE", "REPLICATOR_FAILEDCREATE", "SomeSpecialProviderEvent"] to include "CloneTaskEvent"
     # ./spec/models/ems_event_spec.rb:232:in `block (3 levels) in <top (required)>'
Finished in 10 minutes 3 seconds (files took 13.89 seconds to load)

@jrafanie
Copy link
Member

jrafanie commented Jun 5, 2017

@imtayadeway those test failures should be fixed by ManageIQ/manageiq-providers-openstack#53

@imtayadeway
Copy link
Contributor Author

@jrafanie thanks for tracking that down! Restarting the build now

@imtayadeway imtayadeway closed this Jun 5, 2017
@imtayadeway imtayadeway reopened this Jun 5, 2017
@isimluk isimluk assigned isimluk and unassigned jrafanie Jun 6, 2017
@isimluk
Copy link
Member

isimluk commented Jun 6, 2017

I think this affects fine as well adding label.

@isimluk isimluk merged commit 0debdf0 into ManageIQ:master Jun 6, 2017
@chessbyte chessbyte added this to the Sprint 62 Ending Jun 5, 2017 milestone Jun 7, 2017
simaishi pushed a commit that referenced this pull request Jun 12, 2017
…ests

Put time back the way we found it
(cherry picked from commit 0debdf0)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 94a08e503801d3d2c85e981ce203a918108fabf4
Author: Šimon Lukašík <isimluk@fedoraproject.org>
Date:   Tue Jun 6 12:03:26 2017 +0200

    Merge pull request #15301 from imtayadeway/bug/fix-interacting-time-tests
    
    Put time back the way we found it
    (cherry picked from commit 0debdf08cb93bb48b464811a40c66dd09565e56b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants