-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put time back the way we found it #15301
Put time back the way we found it #15301
Conversation
These tests use `Timecop.travel` without `Timecop.return`, causing another test in another part of the suite to fail. To reproduce: ``` SPEC_OPTS=--seed=30045 bundle exec rspec ./spec/models/job_spec.rb[1:1:7:1:1] ./spec/requests/api/logging_spec.rb[1:1:4] ``` Fixes ManageIQ#15290
Checked commit imtayadeway@ba17014 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@imtayadeway ugh, tests are failing
|
@imtayadeway those test failures should be fixed by ManageIQ/manageiq-providers-openstack#53 |
@jrafanie thanks for tracking that down! Restarting the build now |
I think this affects fine as well adding label. |
…ests Put time back the way we found it (cherry picked from commit 0debdf0)
Fine backport details:
|
These tests use
Timecop.travel
withoutTimecop.return
, causinganother test in another part of the suite to fail. To reproduce:
Fixes #15290
@miq-bot add-label bug/sporadic test failure
@miq-bot assign @jrafanie