Lower the report level of routine http errors in the Fog log #15363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FogLogger was automatically reporting every Excon error (400+ status code) as an ERROR level message, which was then getting mirrored without context into the evm.log as an ERROR. The application already catches, handles, and logs these occurances with relevant context, so the automatic instrumentation only needs to report the gritty details of these events at the DEBUG level.
|
Checked commit mansam@4c16bb1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FogLogger was automatically reporting every Excon error (400+ status
code) as an ERROR level message, which was then getting mirrored without
context into the evm.log as an ERROR. The application already catches,
handles, and logs these occurrences with relevant context, so the automatic
instrumentation only needs to report the gritty details of these events
at the DEBUG level.
For example, OpenstackHandle's
handled_listtotally assumes that it will get 404s for normal reasons and outputs WARNs with relevant messages explaining the occurrence in the Fog log. However, because the instrumentation was automatically reporting every lack of success as an ERROR, you get a WARN and an ERROR for the same thing in the Fog log, and a confusing ERROR by itself for a thing that didn't actually fail in the EVM log.Fixes the log spam reported in https://bugzilla.redhat.com/show_bug.cgi?id=1447664