Format time interval for log message #15370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
fix-time-format-in-logging-wjen-task-expired
branch
from
c87511e
to
8aa72fd
Compare
|
@miq-bot assign @gtanzillo |
yrudman
force-pushed
the
fix-time-format-in-logging-wjen-task-expired
branch
from
8aa72fd
to
a3fd4bd
Compare
gtanzillo
reviewed
Jun 16, 2017
app/models/miq_task.rb
Outdated
| @@ -40,7 +40,7 @@ class MiqTask < ApplicationRecord | |||
| def self.update_status_for_timed_out_active_tasks | |||
| MiqTask.active.timed_out.no_associated_job.find_each do |task| | |||
| task.update_status(STATE_FINISHED, STATUS_ERROR, | |||
| "Task [#{task.id}] timed out - not active for more than #{::Settings.task.active_task_timeout}") | |||
| "Task [#{task.id}] timed out - not active for more than #{::Settings.task.active_task_timeout.tr(".", " ")}") | |||
There was a problem hiding this comment.
Maybe do it this way because, although it doesn't read as nicely, it's safer -
"#{::Settings.task.active_task_timeout.to_i_with_method} seconds"
yrudman
force-pushed
the
fix-time-format-in-logging-wjen-task-expired
branch
from
a3fd4bd
to
2f71cb4
Compare
|
Checked commit yrudman@2f71cb4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Fine backport details: |
simaishi
pushed a commit
that referenced
this pull request
Jun 16, 2017
…n-task-expired Format time interval for log message (cherry picked from commit 0f95dd1) https://bugzilla.redhat.com/show_bug.cgi?id=1460349
simaishi
pushed a commit
that referenced
this pull request
Jun 30, 2017
…n-task-expired Format time interval for log message (cherry picked from commit 0f95dd1) https://bugzilla.redhat.com/show_bug.cgi?id=1457979
|
Euwe backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: Time interval (when task got expired) recorded to log exactly as present in settings.yaml. Example:
10.minutesbut should be10 minutesBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1457979
@miq-bot add-label bug, core
\cc @gtanzillo