Validate presence of feed on middleware servers #15390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@himdel Cannot apply the following label because they are not recognized: providers/middleware |
|
@miq-bot add_label providers/hawkular |
Hawkular's MiddlewareServer relies on feed not being nil. Adding a `validates_presence` to be sure. And fixing the factory to always create a feed - to remove the need to always provide `feed` when mocking to prevent errors from `CGI.unescape`.
|
Checked commit https://github.com/himdel/manageiq/commit/cd9b52558de201a0dfca36d283b1b76d4e0eb128 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
israel-hdez
reviewed
Jun 16, 2017
|
@miq-bot add_label enhancement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hawkular's MiddlewareServer relies on feed not being nil => adding a
validates_presenceto be sure.And fixing the factory to always create a feed - to remove the need to always provide
feedwhen mocking to prevent errors fromCGI.unescape.(This recently caused ui-classic spec failures, fixed temporarily in ManageIQ/manageiq-ui-classic#1540 by adding that
feedeverywhere, but since according to @israel-hdez (in https://github.com/ManageIQ/manageiq-providers-hawkular/pull/20/files#r121929594), afeedis always there, seems that this is the right place to fix.)@israel-hdez WDYT?