Rebuild Provision Requests with arrays #15410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug @miq-bot add_label bug |
gmcculloug
reviewed
Jun 20, 2017
tools/rebuild_provision_request.rb
Outdated
| @@ -72,6 +72,8 @@ | |||
| class Tab | |||
| attr_reader :output, :log | |||
|
|
|||
| FIELD_ARRAY = [:security_groups].freeze | |||
There was a problem hiding this comment.
I jokingly want to call this FIELD_ARRAY_ARRAY but maybe a more realistic name would be ARRAY_FIELD_NAMES?
If a field is included in the FIELD_ARRAY constant, we allow the resulting values returned as arrays.
syncrou
force-pushed
the
rebuild_provision_request_sec_group_arrays
branch
from
87043b9
to
a5404e1
Compare
|
Checked commit syncrou@a5404e1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field is included in the FIELD_ARRAY constant, we allow the resulting values returned as arrays.