Collect log follows symlink recursively to the origin file #15420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yrudman tested both symlink to dir, one and two levels of symlink, failed to pack one of the files won't make whole collecting zip fail. Ready for review. Note in my vm for testing, even the GUID file is not a symlink originally. So I move it to other place, and tested by symlink to symlink to it (two levels) or symlink to it (one level). |
ailisp
force-pushed
the
bug-1450134
branch
2 times, most recently
from
80d5423
to
4127af2
Compare
yrudman
reviewed
Jun 22, 2017
spec/lib/vmdb/util_spec.rb
Outdated
|
|
||
| it "symlink file" do | ||
| origin_file = Tempfile.new 'origin' | ||
| origin_file.puts('abc') |
|
👍 looks good Very minor, could you rebase and squash to 2 commits |
ailisp
changed the title
|
@miq-bot remove-label wip |
|
Checked commits ailisp/manageiq@2063a76~...43f9e83 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gtanzillo can this be |
|
@miq-bot add-label fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Aug 4, 2017
Collect log follows symlink recursively to the origin file (cherry picked from commit 81d5567) https://bugzilla.redhat.com/show_bug.cgi?id=1478510
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Collect log follows symlink recursively to the origin file (cherry picked from commit 81d5567) https://bugzilla.redhat.com/show_bug.cgi?id=1478510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: When collecting log using diagnostic panel of ManageIQ Configuration, when encounter symlinks, it only collect symlink, not the actual file.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1450134
\cc @yrudman @gtanzillo
@miq-bot add-label wip, bug