Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the Ansible service in containers rather than starting it locally #15423

Merged
merged 6 commits into from
Jun 27, 2017
Merged

Use the Ansible service in containers rather than starting it locally #15423

merged 6 commits into from
Jun 27, 2017

Commits on Jun 26, 2017

  1. Use the ansible service name for the provider URL in containers 

    When we know we are running in a container (read: OpenShift) we
also know that embedded ansible will be provided as a separate
service. So rather than pointing at one of our servers as the
provider URL, use the service name.
    @carbonin
    carbonin committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    36ea0ea View commit details
    Browse the repository at this point in the history

  2. Stub out some service-centric EmbeddedAnsible methods in a container 

    We don't need to concern ourselves with trying to manage the
ansible services when we are in a container because we will be
running them as a separate container and contacting the API through
a service rather than locally.
    @carbonin
    carbonin committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    73992a4 View commit details
    Browse the repository at this point in the history

  3. Make EmbeddedAnsible.api_connection use the service when in a container 

    This also sets verify_ssl to 0 for this connection.
This is okay because in the appliance case we are communicating locally
and in the container case we are communicating within the openshift
project.
    @carbonin
    carbonin committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    0e9aed4 View commit details
    Browse the repository at this point in the history

  4. Make EmbeddedAnsible.start container aware 

    If we are in a container we don't attempt to start any of the
services locally, but we set the password appropriatly and
wait for the service to be available
    @carbonin
    carbonin committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    2115b1b View commit details
    Browse the repository at this point in the history

  5. Delete the ANSIBLE_SERVICE_NAME environment variable in specs 

    This shouldn't really be set anywhere we are running the specs
    @carbonin
    carbonin committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    1ad05ba View commit details
    Browse the repository at this point in the history

  6. Use break rather than return for loops

    @carbonin
    carbonin committed Jun 26, 2017
    Configuration menu
    Copy the full SHA
    dee942b View commit details
    Browse the repository at this point in the history