Fix key for regexp in miq_expression.yaml #15452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there is lot of occurencies of :regexp miq_expresion.rb and also in app/controllers/application_controller/filter/expression.rb and it fixes editing of expression with regexp in UI (report definition, filter tab) so there is typo in yaml.
|
Checked commit lpichler@2d56185 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
This PR should fix BZ https://bugzilla.redhat.com/show_bug.cgi?id=1447374 |
simaishi
pushed a commit
that referenced
this pull request
Aug 2, 2017
Fix key for regexp in miq_expression.yaml (cherry picked from commit 1a66602) https://bugzilla.redhat.com/show_bug.cgi?id=1477702 https://bugzilla.redhat.com/show_bug.cgi?id=1477701
|
Made the change to Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Fix key for regexp in miq_expression.yaml (cherry picked from commit 1a66602) https://bugzilla.redhat.com/show_bug.cgi?id=1477702 https://bugzilla.redhat.com/show_bug.cgi?id=1477701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a lot of occurrences of
:regexpmiq_expresion.rb and also in
app/controllers/application_controller/filter/expression.rb
and it fixes to edit of expression with regexp in UI
(report definition, filter tab)
so there is the typo in yaml.
UI error:
before:
after:
@miq-bot add_label reporting, bug
@miq-bot assign @gtanzillo