Change the criteria for a required field of ContainerTemplateServiceDialog. #15469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcculloug
reviewed
Jun 29, 2017
| @@ -74,7 +74,7 @@ def add_parameter_field(param, group, position) | |||
| :name => "param_#{param.name}", | |||
| :data_type => "string", | |||
| :display => "edit", | |||
| :required => param.required, | |||
| :required => param.required && param.generate.nil?, | |||
There was a problem hiding this comment.
@lfu Overall this looks good. Just wondering if param.gererate could ever be an empty string. Suggest using param.generate.blank? unless you know or it is documented to always be nil in this case.
…ialog. When a container template parameter is required but with auto-generated option, it is not a required service dialog field.
lfu
force-pushed
the
required_field_container_service_dialog
branch
from
bb4d59b
to
1d8a461
Compare
|
@gmcculloug Updated. |
|
Checked commit lfu@1d8a461 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
gmcculloug
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a container template parameter is required but with auto-generated option, it is not a required service dialog field.
In other words, the dialog field is considered as required only if the container template parameter is required without auto-generated option.
@miq-bot assign @gmcculloug
@miq-bot add_label services, enhancement, providers/containers
cc @bzwei