Container Template: Add :miq_class for each object #15475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label providers/containers, enhancement |
|
Checked commit zakiva@2de55f8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
LGTM 👍 |
|
Testing is covered by specs in ManageIQ/manageiq-providers-openshift#27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
miq_classattribute to each object (hash) that returned byinstantiatemethod, instead of converting thekindattribute since the resource kind is needed in order to allow automation to rollback in case of a service failure.