Checks PXE customization templates for unique names

[d-m-u]

PXE customization templates shouldn't allow duplicates by name. Fix for https://bugzilla.redhat.com/show_bug.cgi?id=1449116

[gmcculloug]

@bdunne The commit comment from 800ae9e8 on Aug 3 2012 (when this line was commented out) said only: Temporarily commented out complex name validation as it is causing issues.

Any thoughts? I'm not sure why this would cause an issue. Only thing I could come up with is multi-regions.

[bdunne]

Yeah, I think this needs to validate uniqueness within a region.

[gmcculloug]

@gtanzillo Any thoughts here or examples you can point us at for this? Do we scope other resources by region?

[bdunne]

https://github.com/ManageIQ/manageiq/blob/master/app/models/dialog.rb#L15

[gtanzillo]

@gmcculloug We do this in a bunch of places. In addition to the place Brandon referenced, we are also doing it for users and groups
https://github.com/manageiq/manageiq/blob/18e29cc304486d4de000b24f75b5024b64364aa7/app/models/miq_group.rb#L22-L22
https://github.com/manageiq/manageiq/blob/6a795af70992bc47b6223ca3c167fab3d3b610fb/app/models/user.rb#L38-L38

[d-m-u]

@miq-bot remove_label wip

[miq-bot]

Checked commit d-m-u@789ddfc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[simaishi]

Fine backport details:

$ git log -1
commit 7c1d133031939805f16250e33b5f4ea34efdfc71
Author: Greg McCullough <gmccullo@redhat.com>
Date:   Thu Jul 6 08:17:29 2017 -0400

    Merge pull request #15495 from d-m-u/unique_pxe_customization_template_name
    
    Checks PXE customization templates for unique names
    (cherry picked from commit aca086c5022d5dacf1a98748b33fe79b56343414)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518368

[simaishi]

@d-m-u @gmcculloug Can/should we backport this to Euwe branch as per flag on the BZ?