Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL to Compute/Containers/Containers in miq_shortcuts #15497

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Fix URL to Compute/Containers/Containers in miq_shortcuts #15497

merged 1 commit into from
Jul 6, 2017

Conversation

jzigmund
Copy link

@jzigmund jzigmund commented Jul 3, 2017

Replace container/explorer with proper action URL (container/show_list)

https://bugzilla.redhat.com/show_bug.cgi?id=1466350

@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2017

Checked commit jzigmund@205c348 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@chessbyte chessbyte requested a review from h-kataria July 5, 2017 13:54
@chessbyte chessbyte self-assigned this Jul 5, 2017
@chrispy1
Copy link

chrispy1 commented Jul 6, 2017

@miq-bot add_label fine/yes
@miq-bot add_label blocker

@dclarizio
Copy link

@chessbyte looks good to me, the containers page is a show_list, not explorer screen. 👍 to go!

h-kataria
h-kataria approved these changes Jul 6, 2017
View reviewed changes
Copy link
Contributor

@h-kataria h-kataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chessbyte chessbyte merged commit 52a875b into ManageIQ:master Jul 6, 2017
@chessbyte chessbyte added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 6, 2017
simaishi pushed a commit that referenced this pull request Jul 7, 2017
@chessbyte @simaishi
Merge pull request #15497 from jzigmund/bz1466350-fix_containers_show…
f17dbea 
…_list_url

Fix URL to Compute/Containers/Containers in miq_shortcuts
(cherry picked from commit 52a875b)

https://bugzilla.redhat.com/show_bug.cgi?id=1468380
@simaishi
Copy link
Contributor

simaishi commented Jul 7, 2017

Fine backport details:

$ git log -1
commit f17dbea3ad5692d5df17ea727b6ea213c779feb9
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Thu Jul 6 16:41:42 2017 -0400

    Merge pull request #15497 from jzigmund/bz1466350-fix_containers_show_list_url
    
    Fix URL to Compute/Containers/Containers in miq_shortcuts
    (cherry picked from commit 52a875b0a70ad2de84151492e5c43a47d1fe9fad)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1468380

@simaishi simaishi mentioned this pull request Dec 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-kataria h-kataria h-kataria approved these changes

Assignees

@chessbyte chessbyte

Labels
blocker bug fine/backported ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jzigmund @miq-bot @chrispy1 @dclarizio @simaishi @h-kataria @chessbyte