Use full path in the Gemfile #15503
Use full path in the Gemfile #15503
Conversation
|
We shouldn't use relative paths in the Gemfile, hence why I made this PR. However, I don't think this "fixes" the --no-deployment nonsense, because gem references are
Combine that with the double-bundle-install in the plugin repos [1], and it will still fail. We still need to get rid of the double-bundle-install. cc @bdunne @durandom on this bit. |
|
@Fryguy This will not work, and I did already try: ManageIQ/manageiq-ui-classic#1606 (comment) Bundler, as far as I can tell, will evaluate and save The bug that I brought up to bundler, rubygems/bundler#5817, does attempt to solve this to some degree, but I think the other bug that might exist is the evaluating the An easy way to test that this doesn't work is to check this branch out, symlink |
I know...
My argument is we should never have relative paths in the Gemfile, regardless. |
|
My apologies, I missed the comment under the PR description. I guess you can ignore my comment. Fine with this being more verbose and exact if that was the intent. |
|
This pull request is not mergeable. Please rebase and repush. |
Relative pathing can have problems if the pwd is not the manageiq directory. This ensures the correct path. Related: - ManageIQ#14525 - ManageIQ/manageiq-ui-classic#1606 - ManageIQ/manageiq-content#136
Fryguy
force-pushed
the
expand_path_mime_types
branch
from
1a8c47e to
b78a934
Compare
|
@bdunne Updated |
|
Checked commit Fryguy@b78a934 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Relative pathing can have problems if the pwd is not the manageiq
directory. This ensures the correct path.
Related:
@NickLaMuro Please review
cc @mkanoor @himdel