Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sti mixin to container_image base class #15505

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Adding sti mixin to container_image base class #15505

merged 1 commit into from
Jul 6, 2017

Conversation

enoodle
Copy link

@enoodle enoodle commented Jul 4, 2017

According to ManageIQ/manageiq-providers-openshift#23 (comment) . We already have acts_as_miq_taggable so only adding NewWithTypesStiMixin

@miq-bot
Copy link
Member

miq-bot commented Jul 4, 2017

Checked commit enoodle@9098055 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@chessbyte chessbyte requested a review from simon3z July 5, 2017 13:56
@enoodle
Copy link
Author

enoodle commented Jul 6, 2017

@Fryguy please take a look

@chessbyte chessbyte assigned chessbyte and unassigned bronaghs Jul 6, 2017
@chessbyte chessbyte merged commit 004f771 into ManageIQ:master Jul 6, 2017
@chessbyte chessbyte added this to the Sprint 64 Ending Jul 10, 2017 milestone Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon3z simon3z Awaiting requested review from simon3z

Assignees

@chessbyte chessbyte

Labels
enhancement providers/containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enoodle @miq-bot @chessbyte @bronaghs