Add my_zone to Service Orchestration. #15533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot assign @gmcculloug |
gmcculloug
reviewed
Jul 10, 2017
app/models/service_orchestration.rb
Outdated
| @@ -83,6 +83,10 @@ def post_provision_configure | |||
| assign_vms_owner | |||
| end | |||
|
|
|||
| def my_zone | |||
| service_template.try(:my_zone) | |||
There was a problem hiding this comment.
As discussed the problem with using service_template is that it can be deleted or changed to reference a different provider from when the service was deployed. Better to reference the provider from the service_resources relationship to lookup the zone and use super if that is nil.
There was a problem hiding this comment.
@gmcculloug Changed as discussed.
Zone is available through the Service VMs, but is incorrect when there are no Service VMs. https://bugzilla.redhat.com/show_bug.cgi?id=1458011
tinaafitz
force-pushed
the
service_orchestration_zone
branch
from
d7e777b
to
98922b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service Retirement attempts to queue the request_service_retire event to the proper zone which is available through the Service VMs. The zone is nil if there are no Service VMs. Getting the zone from the service_template.my_zone should resolve this issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1458011