Allow operator characters on the RHS of filter #15534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where filters with operator characters on the RHS would return 400s. This is because it parses the operator as the first one found anywhere in the filter. By taking a more LALR-ish approach, we can avoid this problem by parsing it as the first operator found in the string. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1365013
|
Checked commit imtayadeway@1a21138 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@miq-bot assign @gtanzillo |
|
@miq-bot assign @abellotti |
|
LGTM !! Thanks @imtayadeway 🎵 |
|
@imtayadeway @abellotti can/should this be backported to Fine/Euwe branch? |
|
@simaishi it should be possible to backport this to Fine, but can't be easily backported to Euwe |
simaishi
pushed a commit
that referenced
this pull request
Aug 14, 2017
…n-rhs Allow operator characters on the RHS of filter (cherry picked from commit d9cd967) https://bugzilla.redhat.com/show_bug.cgi?id=1481296
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…rators-on-rhs Allow operator characters on the RHS of filter (cherry picked from commit d9cd967) https://bugzilla.redhat.com/show_bug.cgi?id=1481296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where filters with operator characters on the RHS would
return 400s. This is because it parses the operator as the first one
found anywhere in the filter. By taking a more LALR-ish approach, we
can avoid this problem by parsing it as the first operator found in
the string.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1365013
@miq-bot add-label bug, api
@miq-bot assign @abellotti