Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query by multiple tags #15557

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Query by multiple tags #15557

merged 1 commit into from
Jul 24, 2017

Conversation

jntullo
Copy link

@jntullo jntullo commented Jul 12, 2017

Minor change to querying with the by_tag param will allow for multiple tags to be specified.

By adding :separator => ',' when calling find_tagged_with, a user can now specify multiple tags that the resource should be tagged by.
ie:
GET /api/services?by_tag=/environment/dev,/function/db
will return services tagged by both /environment/dev and /function/db

@miq-bot add_label api, enhancement
@miq-bot assign @abellotti

cc: @imtayadeway @AllenBW

@miq-bot
Copy link
Member

miq-bot commented Jul 12, 2017

Checked commit jntullo@9ac1929 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Contributor

@imtayadeway imtayadeway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

@AllenBW
Copy link
Member

AllenBW commented Jul 12, 2017

🌮 💃 😻

@miq-bot miq-bot assigned gtanzillo and unassigned abellotti Jul 13, 2017
@jntullo
Copy link
Author

jntullo commented Jul 24, 2017

@miq-bot assign @abellotti

@miq-bot miq-bot assigned abellotti and unassigned gtanzillo Jul 24, 2017
@abellotti abellotti added this to the Sprint 65 Ending Jul 24, 2017 milestone Jul 24, 2017
@abellotti
Copy link
Member

😍 Thanks @jntullo for the API Enhancement!!

@abellotti abellotti merged commit 71d244b into ManageIQ:master Jul 24, 2017
@chrisarcand chrisarcand deleted the allow_comma_separated_tags branch November 28, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants