Validate if we have an array of integers #15572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label wip, bug @miq-bot assign @gmcculloug |
miq-bot
changed the title
syncrou
force-pushed
the
array_of_integers
branch
from
b465aa0
to
83d51ee
Compare
|
@miq-bot remove_label wip @gmcculloug - The PR reflects the changes we chatted about. |
miq-bot
changed the title
gmcculloug
reviewed
Jul 18, 2017
app/models/miq_request_workflow.rb
Outdated
| @@ -143,8 +143,7 @@ def validate(values) | |||
|
|
|||
| # Check the disabled flag here so we reset the "error" value on each field | |||
| next if dialog_disabled || fld[:display] == :hide | |||
|
|
|||
| value = get_value(values[f]) | |||
| value = fld[:data_type].to_s.match('array_') ? values[f] : get_value(values[f]) | |||
There was a problem hiding this comment.
Following rubocop here and suggest we change this to =~ since we are not using the returned MatchData object. It also removes the need for to_s.
The get_value method was always returning the first value if an array was passed in. This change modifies the logic to return the original data if an array of integers is passed in or if a non array is passed in. Without this change, the validation on the dialog was failing for the array_integer type
syncrou
force-pushed
the
array_of_integers
branch
from
83d51ee
to
5107240
Compare
|
Checked commit syncrou@5107240 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/models/miq_request_workflow.rb
|
gmcculloug
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_valuemethod was always returning the first value if an array was passed in.This change modifies the logic to return the original data if an array of integers is passed in or
if a non array is passed in.
Without this change, the validation on the dialog was failing for the
array_integertype as seen from Travis