choose build pod by name AND namespace #15575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoodle
force-pushed
the
namespace_container_build_pod_identification
branch
from
f3b2c4c
to
9fb39d3
Compare
|
@cben @moolitayer PTAL at this one liner |
|
Checked commit enoodle@9fb39d3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@enoodle is there a ticket associated with this bug? |
moolitayer
reviewed
Jul 17, 2017
| @@ -157,7 +157,8 @@ def save_container_groups_inventory(ems, hashes) | |||
| h[:container_node_id] = h.fetch_path(:container_node, :id) | |||
| h[:container_replicator_id] = h.fetch_path(:container_replicator, :id) | |||
| h[:container_project_id] = h.fetch_path(:project, :id) | |||
| h[:container_build_pod_id] = ems.container_build_pods.find_by(:name => h[:build_pod_name]).try(:id) | |||
| h[:container_build_pod_id] = ems.container_build_pods.find_by(:name => h[:build_pod_name], | |||
| :namespace => h.fetch_path(:project, :name)).try(:id) | |||
There was a problem hiding this comment.
It's weird that we have a namespace string and not container_project_id like everywhere else. We should probably fix that
|
@moolitayer This is a bug only in the backend that doesn't have an effect on the ui user experience, I am not sure if I can open a bug for that. |
cben
approved these changes
Jul 17, 2017
|
@blomquisg @Fryguy PTAL |
simon3z
approved these changes
Jul 21, 2017
|
LGTM 👍 |
|
BZ added |
|
ping @blomquisg |
simaishi
pushed a commit
that referenced
this pull request
Aug 4, 2017
…identification choose build pod by name AND namespace (cherry picked from commit ed83f8b) https://bugzilla.redhat.com/show_bug.cgi?id=1478568
|
Fine backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
…ild_pod_identification choose build pod by name AND namespace (cherry picked from commit ed83f8b) https://bugzilla.redhat.com/show_bug.cgi?id=1478568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that the ContainerBuildPod associated with a ContainerGroup is from the same namespace.
Tests are in ManageIQ/manageiq-providers-openshift#36 due to the inexistance of tests for this file in this repo.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1474076