[Performance] MiqGroup.seed #15586
Merged
[Performance] MiqGroup.seed #15586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
seeding_timeout_group
branch
from
3bb9c18
to
85c0f15
Compare
lpichler
reviewed
Jul 17, 2017
app/models/miq_group.rb
Outdated
| @@ -60,15 +60,18 @@ def self.seed | |||
| ldap_to_filters = filter_map_file.exist? ? YAML.load_file(filter_map_file) : {} | |||
| root_tenant = Tenant.root_tenant | |||
|
|
|||
| groups = where(:group_type => SYSTEM_GROUP).includes(:entitlement).index_by(&:description) | |||
| roles = MiqUserRole.where("name like '%EvmRole-%'").index_by(&:name) | |||
There was a problem hiding this comment.
Shouldn't be here only ....where("name like 'EvmRole-%'") ? regard to access to hash by index beginning on 'EvmRole...' on line 68 ?
assigning miq_user_role was causing a bunch of sub queries
Simple N+1 fix
kbrock
force-pushed
the
seeding_timeout_group
branch
from
85c0f15
to
a7e6518
Compare
|
Checked commits kbrock/manageiq@09d354d~...a7e6518 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
This was referenced Jul 27, 2017
bdunne
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeding occurs for every boot of every evmserver. It is also in a mutex.
So reducing timing and queries is important for us
Focusing on top 10 worst offenders
group.miq_user_rolewas causing a bunch of sub queries, so we added anifblockServerRolecommentsMiqGroupbeforeMiqGroupafterdelta* Memory usage does not reflect 921 freed objects.
commentsServerRolebeforeServerRoleafter* Memory usage does not reflect 134 freed objects.
Spurred by
https://bugzilla.redhat.com/show_bug.cgi?id=1422671