Seeding timeout #15595
Merged
Seeding timeout #15595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
requested changes
Jul 31, 2017
lib/evm_database.rb
Outdated
| @@ -63,10 +63,10 @@ def self.seed(classes = nil, exclude_list = []) | |||
| classes ||= PRIMORDIAL_CLASSES + (seedable_model_class_names - PRIMORDIAL_CLASSES) | |||
| classes -= exclude_list | |||
|
|
|||
| lock_timeout = ENV["SEEDING_LOCK_TIMEOUT"].to_i # default: 600 | |||
| lock_timeout = 10.minutes if lock_timeout.zero? | |||
There was a problem hiding this comment.
Maybe lock_timeout = ENV["SEEDING_LOCK_TIMEOUT"] || 10.minutes
Is there any other time that this is zero?
There was a problem hiding this comment.
That was there to handle a nil or a ""
Will add the to_i and consolidate to one line.
Seeding over a WAN can take longer than 10 minutes. This allows the timeout to be increased temporarily. https://bugzilla.redhat.com/show_bug.cgi?id=1422671
|
Checked commit kbrock@d082c47 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Since seeding can only be performed on one system at a time, we set a timeout to limit our blocking of systems.
The initial seeding over a WAN can take longer than our timeout of 10 minutes.
So the initial seeding times out, the database never gets populated, and the app will never run.
Solution:
Add a variable to temporarily increase the seeding timeout.
This will give the app enough time for the initial seeding of the database.
Since subsequent seeding is quicker, this option (env variable) only needs to be used for the first boot of the application.
In addition, a more descriptive error message has been to the log.
https://bugzilla.redhat.com/show_bug.cgi?id=1422671
To test, I ran:
SEEDING_LOCK_TIMEOUT=1 bundle exec rails db:seed/cc @Fryguy No idea why the other PR closed.