Allow compressed ids when updating a service dialog #15619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit jntullo@a83b583 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
imtayadeway
approved these changes
Jul 20, 2017
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15434
uncompress_idsworks with both non-compressed and compressed ids. Adding this into the update methods allows the API to work with the newly compressed IDs that are passed back@miq-bot add_label bug, api, services
@miq-bot assign @gtanzillo
cc: @martinpovolny @imtayadeway