Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge retirement checks #15645

Merged
merged 7 commits into from
Jul 26, 2017
Merged

Commits on Jul 24, 2017

  1. Bundle all retirement checks into a single queue job

    By default we run retirement_check for Vms, Services, LoadBalancers and
    OrchestrationStacks every 10 minutes.
    
    Most of the time, retirement_check results into no-op. However, it has
    fixed costs attached.
     - it inserts, selects updates, and deletes from MiqQueue
     - it locks miq_queue_lock
     - it synces log messages (they grow)
     - it takes worker's time to process
    
    Every 10 minutes.
    
    Moreover, the code base is very similar -> no point of having it so
    many times. Every method defined increases our footprint. Every penny
    counts.
    
    Even in cases, your set-up uses retirement dates heavily, each run will
    go through really quickly -> so there is not reason for separation. The
    work is already too small, to divide into multiple jobs.
    isimluk authored and d-m-u committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    17412ff View commit details
    Browse the repository at this point in the history
  2. Remove extra files

    isimluk authored and d-m-u committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    99052b6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    801b94e View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2017

  1. Configuration menu
    Copy the full SHA
    6b1c86d View commit details
    Browse the repository at this point in the history
  2. Create a scope for items not scheduled for retirement

    Define the scope in the RetirementMixin
    bdunne committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    9cf27b1 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from bdunne/not_scheduled_for_retirement_scope

    Create a scope for items not scheduled for retirement
    d-m-u authored Jul 26, 2017
    Configuration menu
    Copy the full SHA
    9ad76a3 View commit details
    Browse the repository at this point in the history
  4. Fix test syntax issues

    d-m-u committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    9e36f18 View commit details
    Browse the repository at this point in the history