Include EvmRole-reader as read-only role in the fixtures #15647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rsevilla87 i found few of the features that have missing view access, please see attached screen-shots
|
rsevilla87
force-pushed
the
master
branch
2 times, most recently
from
45fa532
to
e2765e0
Compare
|
Checked commit rsevilla87@9292c18 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
h-kataria
approved these changes
Jul 26, 2017
|
@dclarizio There is a request to backport this to Fine branch. Would that be OK? |
|
@simaishi this looks good to me to be backported to Fine branch. |
|
@h-kataria Thanks. |
|
@simaishi , no there is not BZ, I'll open it |
simaishi
pushed a commit
that referenced
this pull request
Aug 24, 2017
Include EvmRole-reader as read-only role in the fixtures (cherry picked from commit 78fb6b4) https://bugzilla.redhat.com/show_bug.cgi?id=1484901
|
Fine backport details: |
|
@h-kataria Is it ok to backport this to Euwe branch as well? |
|
@simaishi looks safe to be backported to EUWE |
|
@h-kataria thanks! |
simaishi
pushed a commit
that referenced
this pull request
Aug 31, 2017
Include EvmRole-reader as read-only role in the fixtures (cherry picked from commit 78fb6b4) https://bugzilla.redhat.com/show_bug.cgi?id=1487289
|
Changed Euwe backport details: |
d-m-u
pushed a commit
to d-m-u/manageiq
that referenced
this pull request
Jun 6, 2018
Include EvmRole-reader as read-only role in the fixtures (cherry picked from commit 78fb6b4) https://bugzilla.redhat.com/show_bug.cgi?id=1484901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no read-only user role defined in the default roles. This role always is useful and requested by the final users, so I think including it and a group associated with it in the fixtures is a good fact to improve the VMDB initial deployment.