Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EUWE] Prevent iteration over all tenants when picking default tenant #15656

Merged
merged 2 commits into from
Aug 23, 2017
Merged

[EUWE] Prevent iteration over all tenants when picking default tenant #15656

merged 2 commits into from
Aug 23, 2017

Conversation

tzumainn
Copy link
Contributor

@tzumainn tzumainn commented Jul 26, 2017 •
edited by simaishi
Loading

@tzumainn tzumainn mentioned this pull request Jul 26, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2017

Checked commits tzumainn/manageiq@bb5121c~...9b6c454 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 2 offenses detected

gems/pending/openstack/openstack_handle/handle.rb

spec/models/manageiq/providers/openstack/infra_manager/refresher_rhos_juno_spec.rb

@miq-bot
Copy link
Member

miq-bot commented Jul 26, 2017

Some comments on commits tzumainn/manageiq@bb5121c~...9b6c454

spec/vcr_cassettes/manageiq/providers/openstack/infra_manager/refresher_rhos_juno.yml

  • ⚠️ - 144545 - Detected pp. Remove all debugging statements.
  • ⚠️ - 144547 - Detected pp. Remove all debugging statements.
  • ⚠️ - 144553 - Detected pp. Remove all debugging statements.
  • ⚠️ - 144643 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145071 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145476 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145567 - Detected pp. Remove all debugging statements.
  • ⚠️ - 16601 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18378 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18554 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41151 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4116 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41792 - Detected pp. Remove all debugging statements.
  • ⚠️ - 42444 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43122 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43175 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43203 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43208 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43301 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4404 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4406 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46244 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46306 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46460 - Detected pp. Remove all debugging statements.
  • ⚠️ - 70919 - Detected pp. Remove all debugging statements.
  • ⚠️ - 70957 - Detected pp. Remove all debugging statements.
  • ⚠️ - 70958 - Detected pp. Remove all debugging statements.

spec/vcr_cassettes/manageiq/providers/openstack/infra_manager/refresher_rhos_juno_maintenance.yml

  • ⚠️ - 144545 - Detected pp. Remove all debugging statements.
  • ⚠️ - 144547 - Detected pp. Remove all debugging statements.
  • ⚠️ - 144553 - Detected pp. Remove all debugging statements.
  • ⚠️ - 144643 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145071 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145476 - Detected pp. Remove all debugging statements.
  • ⚠️ - 145567 - Detected pp. Remove all debugging statements.
  • ⚠️ - 16601 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18378 - Detected pp. Remove all debugging statements.
  • ⚠️ - 18554 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203632 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203920 - Detected pp. Remove all debugging statements.
  • ⚠️ - 203922 - Detected pp. Remove all debugging statements.
  • ⚠️ - 216117 - Detected pp. Remove all debugging statements.
  • ⚠️ - 217894 - Detected pp. Remove all debugging statements.
  • ⚠️ - 218070 - Detected pp. Remove all debugging statements.
  • ⚠️ - 240667 - Detected pp. Remove all debugging statements.
  • ⚠️ - 241308 - Detected pp. Remove all debugging statements.
  • ⚠️ - 241960 - Detected pp. Remove all debugging statements.
  • ⚠️ - 242638 - Detected pp. Remove all debugging statements.
  • ⚠️ - 242691 - Detected pp. Remove all debugging statements.
  • ⚠️ - 242719 - Detected pp. Remove all debugging statements.
  • ⚠️ - 242724 - Detected pp. Remove all debugging statements.
  • ⚠️ - 242817 - Detected pp. Remove all debugging statements.
  • ⚠️ - 245760 - Detected pp. Remove all debugging statements.
  • ⚠️ - 245822 - Detected pp. Remove all debugging statements.
  • ⚠️ - 245976 - Detected pp. Remove all debugging statements.
  • ⚠️ - 270435 - Detected pp. Remove all debugging statements.
  • ⚠️ - 270473 - Detected pp. Remove all debugging statements.
  • ⚠️ - 270474 - Detected pp. Remove all debugging statements.
  • ⚠️ - 344061 - Detected pp. Remove all debugging statements.
  • ⚠️ - 344063 - Detected pp. Remove all debugging statements.
  • ⚠️ - 344069 - Detected pp. Remove all debugging statements.
  • ⚠️ - 344159 - Detected pp. Remove all debugging statements.
  • ⚠️ - 344587 - Detected pp. Remove all debugging statements.
  • ⚠️ - 344992 - Detected pp. Remove all debugging statements.
  • ⚠️ - 345083 - Detected pp. Remove all debugging statements.
  • ⚠️ - 401714 - Detected pp. Remove all debugging statements.
  • ⚠️ - 402002 - Detected pp. Remove all debugging statements.
  • ⚠️ - 402004 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41151 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4116 - Detected pp. Remove all debugging statements.
  • ⚠️ - 414199 - Detected pp. Remove all debugging statements.
  • ⚠️ - 415976 - Detected pp. Remove all debugging statements.
  • ⚠️ - 416152 - Detected pp. Remove all debugging statements.
  • ⚠️ - 41792 - Detected pp. Remove all debugging statements.
  • ⚠️ - 42444 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43122 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43175 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43203 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43208 - Detected pp. Remove all debugging statements.
  • ⚠️ - 43301 - Detected pp. Remove all debugging statements.
  • ⚠️ - 438749 - Detected pp. Remove all debugging statements.
  • ⚠️ - 439390 - Detected pp. Remove all debugging statements.
  • ⚠️ - 440042 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4404 - Detected pp. Remove all debugging statements.
  • ⚠️ - 4406 - Detected pp. Remove all debugging statements.
  • ⚠️ - 440720 - Detected pp. Remove all debugging statements.
  • ⚠️ - 440773 - Detected pp. Remove all debugging statements.
  • ⚠️ - 440801 - Detected pp. Remove all debugging statements.
  • ⚠️ - 440806 - Detected pp. Remove all debugging statements.
  • ⚠️ - 440899 - Detected pp. Remove all debugging statements.
  • ⚠️ - 443842 - Detected pp. Remove all debugging statements.
  • ⚠️ - 443904 - Detected pp. Remove all debugging statements.
  • ⚠️ - 444058 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46244 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46306 - Detected pp. Remove all debugging statements.
  • ⚠️ - 46460 - Detected pp. Remove all debugging statements.
  • ⚠️ - 468517 - Detected pp. Remove all debugging statements.
  • ⚠️ - 468555 - Detected pp. Remove all debugging statements.
  • ⚠️ - 468556 - Detected pp. Remove all debugging statements.
  • ⚠️ - 542143 - Detected pp. Remove all debugging statements.
  • ⚠️ - 542145 - Detected pp. Remove all debugging statements.
  • ⚠️ - 542151 - Detected pp. Remove all debugging statements.
  • ⚠️ - 542241 - Detected pp. Remove all debugging statements.
  • ⚠️ - 542669 - Detected pp. Remove all debugging statements.
  • ⚠️ - 543074 - Detected pp. Remove all debugging statements.
  • ⚠️ - 543165 - Detected pp. Remove all debugging statements.
  • ⚠️ - 70919 - Detected pp. Remove all debugging statements.
  • ⚠️ - 70957 - Detected pp. Remove all debugging statements.
  • ⚠️ - 70958 - Detected pp. Remove all debugging statements.

@tzumainn
Copy link
Contributor Author

Test errors appear to be related to Ansible Tower.

@simaishi simaishi requested a review from aufi July 26, 2017 20:51
@simaishi
Copy link
Contributor

Travis failure is due to #15456. I will restart the job once that's fixed.

@simaishi simaishi self-assigned this Jul 26, 2017
@simaishi simaishi requested a review from mansam July 26, 2017 20:53
@simaishi
Copy link
Contributor

@aufi @mansam ping

mansam
mansam approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simaishi simaishi merged commit a22e0cc into ManageIQ:euwe Aug 23, 2017
@simaishi simaishi added this to the Sprint 68 Ending Sep 11, 2017 milestone Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansam mansam mansam approved these changes

@aufi aufi Awaiting requested review from aufi

Assignees

@simaishi simaishi

Labels
bug providers/infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tzumainn @miq-bot @simaishi @mansam @Fryguy