[EUWE] Display Ansible tower job templates filters #15657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstastna
force-pushed
the
Ansible_tower_job_templates_filters_EUWE
branch
from
7988b11
to
a8f5182
Compare
miq-bot
changed the title
hstastna
changed the title
added 2 commits
July 26, 2017 15:20
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1472381 Display Ansible tower job templates filters in accordion in Configuration -> Management -> Ansible tower job templates. Correct condition in _explorer.html.haml not to fail if nil.
Add missing filters_by_type method to miq search for proper filtering when choosing between Global Filters and My Filters.
hstastna
force-pushed
the
Ansible_tower_job_templates_filters_EUWE
branch
from
f7ecc89
to
f0cb447
Compare
Add proper icons for Global Filters and My Filters in Configuration -> Management -> Ansible Tower Job Templates tab.
|
@miq-bot remove_label wip |
hstastna
changed the title
|
@miq-bot add_label ui, bug |
Edit provider foreman controller spec to fix failing tests when fixing displaying Ansible Tower Job Templates filters.
hstastna
force-pushed
the
Ansible_tower_job_templates_filters_EUWE
branch
from
4ea8c4c
to
c837b73
Compare
|
Checked commits hstastna/manageiq@26dfda8~...c837b73 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
test failures in this PR are unrelated |
|
Restarting travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of ManageIQ/manageiq-ui-classic#1082
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1472381
Display Ansible Tower Job Templates filters in accordion
in Configuration -> Management -> Ansible tower job templates.
Correct condition in
_explorer.html.hamlnot to fail ifnil.