-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support logins when "Get User Groups from LDAP" is not checked #15661
Support logins when "Get User Groups from LDAP" is not checked #15661
Conversation
When not getting groups from LDAP the user is manually created in the DB. It is unlikely the admin will create the user in the UPN or DN formats as return from searching the directory. So this PR will also try to find the user by simple username. https://bugzilla.redhat.com/show_bug.cgi?id=1442791
@gtanzillo and @abellotti please review. |
@miq-bot add_label authentication, bug |
After configuring authentication to not Get User Groups from LDAP and manually creating users, if the authentication configuration is update to Get User Groups from LDAP duplicate user records could be created. I think we can manage this unlikely side effect by documenting it. |
Checked commits jvlcek/manageiq@c045aff~...0119cda with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
@abellotti and @gtanzillo Updates made as discussed. If you are good with this let me know and I will squash the extra commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
When not getting groups from LDAP the user is manually created in
the DB. The name must be created in the format supported by the
directory being used. When the directory is Active Directory the username
must be in UPN format. When the directory is LDAP the username must be the
full DN. The admin will create the user in the UPN or DN formats as return from
searching the given directory.
https://bugzilla.redhat.com/show_bug.cgi?id=1442791
Steps for Testing/QA