Register product feature for stopping domains #15680
Conversation
db/fixtures/miq_product_features.yml
Outdated
| @@ -3971,6 +3971,10 @@ | |||
| :description: Edit Tags of Middleware Domains | |||
| :feature_type: control | |||
| :identifier: middleware_domain_tag | |||
| - :name: Stop Middleware Domain | |||
| :description: Stop Middleware Domain | |||
| :feature_type: admin | |||
There was a problem hiding this comment.
@josejulio normally, start and stop type operations are given a feature type of control. We use admin for CRUD type features. So, I'd think you would want this as a control feature type.
There was a problem hiding this comment.
Whoops, thanks for pointing it out. I'll update that.
There was a problem hiding this comment.
@Fryguy @blomquisg shouldn't operations/features like this be also moved to the relevant provider repos?
@cfcosta fyi
There was a problem hiding this comment.
@dclarizio does this mean that we should change/review our MW features? Similar MW operations have admin on its feature type. Have a look:
manageiq/db/fixtures/miq_product_features.yml
Line 3785 in a139ce6
There was a problem hiding this comment.
@h-kataria can you review the features @israel-hdez has linked to above for consistency with other product areas? Please provide some guidance. Thx, Dan
|
Checked commits josejulio/manageiq@61bf5df~...dd0841b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
Code looks good for me! |
|
@dclarizio, PR is reviewed and approved by 2 developers. ready to merge? |
Adds the required product feature for stopping middleware domains
middleware_domain_stopRequired by:
ManageIQ/manageiq-ui-classic#1753
@miq-bot add_label fine/no, providers/hawkular