Batch disconnect method for ContainerImage

[Ladas]

Batch disconnect method for ContainerImage.

[Ladas]

@miq-bot assign @agrare
@miq-bot add_label enhancement, performance
cc @cben

[cben]

[orthogonal to this PR: @enoodle @zakiva why do we disconnect images from registries? I'd expect us to keep it, and archive registries too.]

[agrare]

Can you more closely match the log message from the normal disconnect_inv ?
Maybe "Disconnecting Images [#{ids}] from EMS [#{ext_management_system.name}] id [#{ext_management_system.id}]"

[Ladas]

right, I don't have the EMS object here. Not sure if I should pass it for the purpose of logging? the EMS can be found in the log by looking at the process id though.

[agrare]

Ah right, just "Disconnecting Images... then

[Ladas]

done

[miq-bot]

Checked commits Ladas/manageiq@2c10dbf~...272744c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 2 offenses detected

app/models/container_image.rb

• ❗ - Line 101, Col 10 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.
• ❗ - Line 102, Col 23 - Rails/SkipsModelValidations - Avoid using update_all because it skips validations.

[agrare]

👍

[cben]

Fun fact: the singular #disconnect_inv methods load ExtManagementSystem for the sole purpose of logging what's disconnected from which EMS.
I'm not sure that happens for every disconnected record in prod, or is somehow cached, but if yes, half the win of batched disconnect is batched logging :-).