Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the target of tag expressions #15715

Merged
merged 2 commits into from
Aug 4, 2017

Conversation

imtayadeway
Copy link
Contributor

Pulled out of #15623

This is needed because entitlement expressions need to be agnostic about their target - it will be set when evaluating through RBAC.

@miq-bot add-label enhancement, core
@miq-bot assign @gtanzillo

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2017

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Aug 2, 2017

Checked commits imtayadeway/manageiq@daf8fed~...c1e6e95 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
6 files checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@gtanzillo gtanzillo added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 4, 2017
@gtanzillo gtanzillo merged commit 979f0e1 into ManageIQ:master Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants