Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remains of container definition #15721

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

zeari
Copy link

@zeari zeari commented Aug 3, 2017

ContainerDefinition and Container were unified to one class, no need for these.
(Plus its generating errors)

@cben @Ladas Please review
cc @simon3z

@miq-bot add_label provider/containers, bug

@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2017

Checked commit zeari@6564544 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Contributor

@cben cben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOLGTM ✂️ 👍

@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2017

@zeari Cannot apply the following label because they are not recognized: provider/containers

@nimrodshn
Copy link
Contributor

Woohoo! 👍

Copy link
Contributor

@simon3z simon3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce! 😊

@Fryguy Fryguy merged commit e7f1555 into ManageIQ:master Aug 4, 2017
@Fryguy Fryguy added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants