Evaluate visibility expressions for CustomButtons

[lpichler]

method CustomButtonSet#filter_with_visibility_expression is called when custom buttons are going to display - the method is doing filtering:

how filter_with_visibility_expression works

(from 36bff47)

  # Params:
  #   custom_button_sets: <Array>CustomButtonSet
  #   object: for this object are evaluated visibility_expression of CustomButtons
  #           one CustomButtonSet contains any CustomButtons,
  #           CustomButtonSet has stored this ids of CustomButtons in array CustomButton#set_data[:button_order]
  # Returns:
  #   <Array>CustomButtonSet
  #
  # example:
  # let's have:
  # custom_buttons_set =
  #   <Array> [<CustomButtonSet> id: 10000000000075,
  #     set_data:
  #       {:button_order=> [1, 2]}, list ids of custom buttons in custom button set (group of buttons in UI)
  # ... ]
  # object = Vm.first
  #
  # then CustomButtonSet.filter_with_visibility_expression(custom_button_sets, object) returns:
  #  - same custom_button_sets array when all visibility expressions are not populated(CustomButton#visibility_expression = nil)
  #  - same custom_button_sets array but with filtered list custom buttons ids in each custom button set from
  #    custom_button_sets when any visibility expression is evaluated to true
  #    - ids of custom buttons with visibility expression which are evaluated to false are removed from CustomButtonSet#set_data[:button_order]
  #  - filtered custom_button_sets array when all visibilty expression custom buttons have been evaluated to false

Links

UI PR: ManageIQ/manageiq-ui-classic#1824
first part of https://www.pivotaltracker.com/story/show/147780767 - visibility of custom buttons

[lpichler]

@miq-bot assign @gtanzillo
cc @martinpovolny
@miq-bot add_label enhancement

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[gtanzillo]

👍 LGTM

[gtanzillo]

@lpichler Please resolve conflict and I'll merge.

[miq-bot]

Checked commits lpichler/manageiq@f1f0be7~...20c194d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 0 offenses detected
Everything looks fine. 👍