Adds dialog field association info to importer #15740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
requested changes
Aug 9, 2017
| associations.each do |association| | ||
| association.values.each do |values| | ||
| values.each do |responder| | ||
| unless new_or_existing_dialog.dialog_fields.select { |field| field.name == responder }.empty? |
There was a problem hiding this comment.
I think this should be a guard clause.
next if .....There was a problem hiding this comment.
I was hoping we could offload some of this to the database, but after further investigation I don't think that's possible right now.
| dialog["dialog_tabs"].flat_map do |tab| | ||
| tab["dialog_groups"].flat_map do |group| | ||
| group["dialog_fields"].flat_map do |field| | ||
| associations << { field["name"] => field["dialog_field_responders"] } unless field["dialog_field_responders"].nil? |
There was a problem hiding this comment.
I hope you're planning to add tests because it's hard to visualize this data structure looks like in my head.
d-m-u
force-pushed
the
adding_associations_to_import
branch
2 times, most recently
from
ca52174
to
bcda199
Compare
d-m-u
changed the title
eclarizio
reviewed
Aug 10, 2017
| allow(dialog_field_importer).to receive(:import_field).and_return(built_dialog_field) | ||
| allow(dialog_field_importer).to receive(:import_field).and_return(built_dialog_field, built_dialog_field2) |
There was a problem hiding this comment.
I think this should just be a change to the previous line instead of an addition.
d-m-u
force-pushed
the
adding_associations_to_import
branch
from
bcda199
to
eb0a6db
Compare
|
Checked commit d-m-u@eb0a6db with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
eclarizio
approved these changes
Aug 10, 2017
bdunne
approved these changes
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates dialog field associations from service dialogs during import. After creating the dialog fields, we set the associations, changing from storing them as names (strings) to storing them by newly created id as required by the new DialogFieldAssociation table.
Related to:
#15608
Depends on:
#15724
@miq-bot add_label enhancement
@miq-bot assign @gmcculloug