Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vm security group operations #15826

Merged
merged 1 commit into from
Aug 31, 2017
Merged

Add vm security group operations #15826

merged 1 commit into from
Aug 31, 2017

Conversation

tzumainn
Copy link
Contributor

No description provided.

@tzumainn tzumainn mentioned this pull request Aug 16, 2017
Merged
@tzumainn
Copy link
Contributor Author

Needed by ManageIQ/manageiq-providers-openstack#79

Tested from rails console.

@miq-bot
Copy link
Member

miq-bot commented Aug 16, 2017

Checked commit tzumainn@d3a4f51 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 2 offenses detected

app/models/mixins/supports_feature_mixin.rb

@tzumainn
Copy link
Contributor Author

As far as I can tell, the hash items are aligned.

@aufi
Copy link
Member

aufi commented Aug 17, 2017

Looks good to me!

@blomquisg
Copy link
Member

@durandom, can you review?

I'm in mobile and it won't let me select a reviewer.

durandom
durandom approved these changes Aug 24, 2017
View reviewed changes
Copy link
Member

@durandom durandom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @blomquisg

@blomquisg blomquisg merged commit 4b31b89 into ManageIQ:master Aug 31, 2017
@blomquisg blomquisg added this to the Sprint 68 Ending Sep 4, 2017 milestone Aug 31, 2017
@NickLaMuro NickLaMuro mentioned this pull request Aug 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aufi aufi aufi approved these changes

@durandom durandom durandom approved these changes

Assignees

@blomquisg blomquisg

Labels
enhancement providers/cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tzumainn @miq-bot @aufi @blomquisg @durandom @Fryguy @chessbyte