Add Openscap Result to VM model #15862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aufi
force-pushed
the
add_openscap_result_to_vm
branch
3 times, most recently
from
1b80748
to
82a3c72
Compare
bdunne
requested changes
Aug 21, 2017
spec/models/vm_or_template_spec.rb
Outdated
| context "#openscap_result" do | ||
| it "has an openscap_result" do | ||
| vm = FactoryGirl.build(:vm) | ||
| expect(vm).to respond_to(:openscap_result) |
There was a problem hiding this comment.
This feels like we're just testing rails. I don't think that's necessary.
There was a problem hiding this comment.
Thanks for comment, removed.
Adding association to Openscap Result for Vm_or_template model to be able to link scan results to multiple Vm types. This is part of Openscap scanning integration to OpenStack provider.
aufi
force-pushed
the
add_openscap_result_to_vm
branch
from
82a3c72
to
aceda57
Compare
|
Checked commit aufi@aceda57 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
bdunne
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding association to Openscap Result for Vm_or_template model to
be able to link scan results to multiple Vm types.
This is part of Openscap scanning integration to OpenStack provider.
Links
Steps for Testing/QA
This PR does not bring new end-user functionality. Will be tested together with OpenStack Openscap integration.