[EUWE] Add config option to skip container_images #15885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM |
agrare
force-pushed
the
euwe_allow_container_images_to_be_skipped
branch
2 times, most recently
from
18b4747
to
1bbb7c4
Compare
…to_be_skipped Add config option to skip container_images (cherry picked from commit d3ebee7)
agrare
force-pushed
the
euwe_allow_container_images_to_be_skipped
branch
from
1bbb7c4
to
d89ceea
Compare
|
Checked commit agrare@d89ceea with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 spec/models/manageiq/providers/openshift/container_manager/refresher_spec.rb
|
agrare
commented
Aug 24, 2017
| @@ -142,6 +142,22 @@ | |||
| end | |||
| end | |||
|
|
|||
| it 'will skip container_images if get_container_images = false' do | |||
| stub_settings(Settings.to_hash.deep_merge( | |||
There was a problem hiding this comment.
There is no stub_settings_merge in euwe so had to do this manually (this is what stub_settings_merge does internally anyway)
|
@simaishi fixed the spec settings failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #14606 to euwe
In some OpenShift environments the number of container images can result
in extremely large API responses to the point where the connection will
timeout, as well as save_inventory times can be dramatically longer.
This adds a config option that if set to false will not request
container images from the /ImageList endpoint and will not parse them in
the RefreshParser.
https://bugzilla.redhat.com/show_bug.cgi?id=1484549